refactor: Replace usage of SmartREST with JSON over MQTT #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rina23q
had a problem deploying
to
Test Pull Request
GitHub Actions
Failure
rina23q
force-pushed
the
refactor-replace-smartrest-with-devicecontrol
branch
from
1659e47 to
9c090c0
Compare
rina23q
had a problem deploying
to
Test Pull Request
GitHub Actions
Failure
rina23q
force-pushed
the
refactor-replace-smartrest-with-devicecontrol
branch
from
9c090c0 to
934cb18
Compare
rina23q
had a problem deploying
to
Test Pull Request
GitHub Actions
Failure
rina23q
force-pushed
the
refactor-replace-smartrest-with-devicecontrol
branch
from
934cb18 to
48738b2
Compare
rina23q
had a problem deploying
to
Test Pull Request
GitHub Actions
Failure
Signed-off-by: Rina Fujino <[email protected]>
Signed-off-by: Rina Fujino <[email protected]>
rina23q
force-pushed
the
refactor-replace-smartrest-with-devicecontrol
branch
from
48738b2 to
07240a8
Compare
rina23q
temporarily deployed
to
Test Pull Request
GitHub Actions
Inactive
Robot Results
Passed Tests
|
rina23q
had a problem deploying
to
Test Pull Request
GitHub Actions
Failure
rina23q
force-pushed
the
refactor-replace-smartrest-with-devicecontrol
branch
from
ba178ea to
65c2f69
Compare
rina23q
had a problem deploying
to
Test Pull Request
GitHub Actions
Failure
rina23q
force-pushed
the
refactor-replace-smartrest-with-devicecontrol
branch
from
65c2f69 to
07c8999
Compare
rina23q
had a problem deploying
to
Test Pull Request
GitHub Actions
Failure
rina23q
force-pushed
the
refactor-replace-smartrest-with-devicecontrol
branch
from
07c8999 to
7af6f67
Compare
rina23q
had a problem deploying
to
Test Pull Request
GitHub Actions
Failure
Signed-off-by: Rina Fujino <[email protected]>
rina23q
force-pushed
the
refactor-replace-smartrest-with-devicecontrol
branch
from
7af6f67 to
a691d13
Compare
rina23q
temporarily deployed
to
Test Pull Request
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the release of thin-edge.io 1.4.0, custom operation handlers can receive messages via JSON over MQTT with the
on_fragmentkey. As a result, themodbus-pluginno longer needs to define and upload own custom SmartREST template to Cumulocity.Thus, this PR removes the existing SmartREST implementation and replaces it with the JSON over MQTT feature.
Also, added system tests for
c8y_SerialConfigurationoperation.Note
c8y_Coilsandc8y_Registersoperation handlers do not appear to be used anywhere. I have modified them to align with this PR's changes, but they remain untested. I assume they are placeholders for supporting write operations.c8y_ModbusDeviceoperation (which is created when you add a Modbus-slave from Cumulocity) is missing.